Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojo::Transaction::success is DEPRECATED #263

Closed
ttimasdf opened this issue Oct 12, 2018 · 9 comments
Closed

Mojo::Transaction::success is DEPRECATED #263

ttimasdf opened this issue Oct 12, 2018 · 9 comments

Comments

@ttimasdf
Copy link

ttimasdf commented Oct 12, 2018

mojolicious/mojo@a443003

现在 Mojo-Webqq 和 Mojo-Weixin 都会打印海量的 warning。

Mojo::Transaction::success is DEPRECATED in favor of Mojo::Transaction::result and Mojo::Transaction::error at /usr/local/share/perl/5.24.1/Mojo/Webqq/Request.pm line 113.
@hexsum
Copy link
Owner

hexsum commented Oct 12, 2018

这个我下周找时间适配下Mojolicious的新版本,好了通知你

@ttimasdf
Copy link
Author

非常感谢~
我找进报错的那个地方把depreciation warning注释掉了,临时的hack,哈哈

@CECoffee
Copy link

怎么解决的?我也是这样,不过是line154

@ttimasdf
Copy link
Author

@Dimerbone 就是issue描述里面的那个commit,把对应报错的那句代码删掉就行。

@CECoffee
Copy link

CECoffee commented Oct 20, 2018 via email

@if1y
Copy link

if1y commented Oct 26, 2018

可是这是个if语句,要把else也删了? 2298843694 邮箱2298843694@qq.com 签名由 网易邮箱大师 定制 On 10/20/2018 17:33, Tim Zhang wrote: @Dimerbone 就是issue描述里面的那个commit,把对应报错的那句代码删掉就行。 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

实测整体删除会获取不到二维码

@CECoffee
Copy link

CECoffee commented Oct 26, 2018 via email

@ttimasdf
Copy link
Author

啊 就是 这行 https://github.com/mojolicious/mojo/blob/master/lib/Mojo/Transaction.pm#L56 和接着的57行。看一眼代码再对应一下报错就明白了。

@hexsum
Copy link
Owner

hexsum commented Nov 22, 2018

v2.2.6版本已修复此问题

@hexsum hexsum closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants