Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate withXSRFToken config option #76

Open
mrlubos opened this issue Mar 18, 2024 · 2 comments
Open

Investigate withXSRFToken config option #76

mrlubos opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
client Client package related feature 🚀 New feature or request

Comments

@mrlubos
Copy link
Contributor

mrlubos commented Mar 18, 2024

ferdikoomen/openapi-typescript-codegen#2067

I'd like to investigate whether we're not forcing our users to use a vulnerable setting, need to check why Axios made that change ferdikoomen/openapi-typescript-codegen#2063 (comment)

@jordanshatford jordanshatford added docs 📃 Improvements or additions to documentation feature 🚀 New feature or request labels Mar 24, 2024
@jordanshatford
Copy link
Collaborator

This can now be done with interceptors:

The use case in the linked PR would look something like this:

OpenAPI.interceptors.request.use((request) => {
  request.withXSRFToken = request.withCredentials
  return request
})

OR

OpenAPI.interceptors.request.use((request) => {
  request.withXSRFToken = OpenAPI.WITH_CREDENTIALS
  return request
})

@mrlubos
Copy link
Contributor Author

mrlubos commented Apr 11, 2024

This will be solved with client packages #308

@mrlubos mrlubos self-assigned this Apr 11, 2024
@mrlubos mrlubos added client Client package related and removed docs 📃 Improvements or additions to documentation labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client package related feature 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants