fix(dropdown): adding accessibility #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 4184249293
💛 - Coveralls |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success250 tests passing in 37 suites. Report generated by 🧪jest coverage report action from e486169 |
|
Compiled a new version demo. |
heyabinanto
reviewed
Feb 10, 2023
esraltintas
approved these changes
Feb 10, 2023
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
heyabinanto
approved these changes
Feb 15, 2023
hcafaq
deleted the
HEYUI-234-add-accessibility-aria-attributes-support-for-dropdown-component
branch
supcar
pushed a commit
that referenced
this pull request
Feb 15, 2023
## [4.2.1](v4.2.0...v4.2.1) (2023-02-15) ### Bug Fixes * **dropdown:** adding accessibility ([#137](#137)) ([5e8cbec](5e8cbec))
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds keyboard accessibility to the dropdown
you can use enter or space key after tab index has highlighted the dropdown, use up and down arrow keys to move and use enter to select again
Type of change
How do I test this
Use enter or space key after tab index has highlighted the dropdown, use up and down arrow keys to move and use enter to select again
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!