Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typography): update typography to match designs #160

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Conversation

nathanjamal
Copy link
Collaborator

Pull Request

Description

added display2 and button + buttonLink 1 to 3

HEYUI-264

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change

How do I test this

  • Add steps to test
  • in bullet point format
  • preferably you can add link to the storybook build in the PR

Checklist

Did you remember to take care of the following?

  • npm i – for new NPM dependencies.
  • npm run lint - to check for linting issues
  • npm run test - to run unit tests
  • npm run test:sh:docker - to run screenshot tests, detail instruction

New Feature / Bug Fix

  • Run unit tests to ensure all existing tests are still passing.
  • Add new passing unit tests to cover the code introduced by your pr.

Thanks for contributing!

added display2 and button + buttonLink 1 to 3
@nathanjamal nathanjamal added the work in progress This is a work in progress label Mar 10, 2023
@coveralls
Copy link

coveralls commented Mar 10, 2023

Pull Request Test Coverage Report for Build 4406566020

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.467%

Totals Coverage Status
Change from base Build 4404115977: 0.0%
Covered Lines: 1082
Relevant Lines: 1101

💛 - Coveralls

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.7% 1188/1216
🟢 Branches 85.53% 266/311
🟢 Functions 94.79% 91/96
🟢 Lines 98.27% 1082/1101

Test suite run success

273 tests passing in 41 suites.

Report generated by 🧪jest coverage report action from ab72a9a

@github-actions
Copy link

Compiled a new version demo.

@github-actions
Copy link

Compiled a new version demo.

@nathanjamal nathanjamal removed the work in progress This is a work in progress label Mar 13, 2023
@nathanjamal nathanjamal changed the title feat(typography): update typography to match designs WIP feat(typography): update typography to match designs Mar 13, 2023
@nathanjamal nathanjamal self-assigned this Mar 15, 2023
@nathanjamal nathanjamal merged commit 9a601a7 into main Mar 15, 2023
@nathanjamal nathanjamal deleted the HEYUI-264 branch March 15, 2023 10:12
supcar pushed a commit that referenced this pull request Mar 15, 2023
# [5.0.0](v4.6.0...v5.0.0) (2023-03-15)

### Features

* **accordion:** remove hover state ([#163](#163)) ([df62524](df62524))
* **badge:** restrict to 3 colors ([#165](#165)) ([3a1f408](3a1f408))
* **logo:** update logo variant names ([#164](#164)) ([6b94211](6b94211))
* **typography:** update typography to match designs ([#160](#160)) ([9a601a7](9a601a7))

### BREAKING CHANGES

* **badge:** using a color other than primary, secondary or tertiary will render the badge in
primary state

HEYUI-268

* defaults to primary styling the if the color prop value is not recognised

* feat(badge): restric to 3 colors

The Badge should only be used in primary, secondary or tertiary
* **badge:** using a color other than primary, secondary or tertiary will render the badge in
primary state

HEYUI-268

* update various tests

* update test
@supcar
Copy link
Collaborator

supcar commented Mar 15, 2023

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants