feat(logo): update logo variant names #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update logo vartiant names to match designs. deprecate color prop and ad usage prop as the new way to select variant. update the docs HEYUI-263
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 4418006617
💛 - Coveralls |
|
Compiled a new version demo. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success273 tests passing in 41 suites. Report generated by 🧪jest coverage report action from c24382b |
esraltintas
approved these changes
Mar 15, 2023
supcar
pushed a commit
that referenced
this pull request
Mar 15, 2023
# [5.0.0](v4.6.0...v5.0.0) (2023-03-15) ### Features * **accordion:** remove hover state ([#163](#163)) ([df62524](df62524)) * **badge:** restrict to 3 colors ([#165](#165)) ([3a1f408](3a1f408)) * **logo:** update logo variant names ([#164](#164)) ([6b94211](6b94211)) * **typography:** update typography to match designs ([#160](#160)) ([9a601a7](9a601a7)) ### BREAKING CHANGES * **badge:** using a color other than primary, secondary or tertiary will render the badge in primary state HEYUI-268 * defaults to primary styling the if the color prop value is not recognised * feat(badge): restric to 3 colors The Badge should only be used in primary, secondary or tertiary * **badge:** using a color other than primary, secondary or tertiary will render the badge in primary state HEYUI-268 * update various tests * update test
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Update logo variant names to match designs.
Deprecate color prop and ad usage prop as the new way to select variant.
Update the docs
HEYUI-263
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!