Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font of text #3

Closed
HeyAnirudh opened this issue Jul 11, 2022 · 6 comments
Closed

Font of text #3

HeyAnirudh opened this issue Jul 11, 2022 · 6 comments
Labels
good first issue Good for newcomers HSOC22-Level-1 5 points HSOC22 For participant of HSOC22

Comments

@HeyAnirudh
Copy link
Owner

adding new fonts in the text. you could explore OpenCV fonts etc.

@HeyAnirudh HeyAnirudh added the good first issue Good for newcomers label Jul 11, 2022
@Beatrix-droid
Copy link

could you assign this to me please?

@HeyAnirudh
Copy link
Owner Author

could you assign this to me please?

done!

@Beatrix-droid
Copy link

Beatrix-droid commented Jul 12, 2022

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app:
My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values:
'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png')
and
"images\\img.png")

because the way linux organises the file system is a bit different (ie there is no C drive for example).

Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

@HeyAnirudh
Copy link
Owner Author

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")

because the way linux organises the file system is a bit different (ie there is no C drive for example).

Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

@Beatrix-droid
Copy link

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")
because the way linux organises the file system is a bit different (ie there is no C drive for example).
Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

My apologies, I had some spare time this morning, and unfortunately have already fixed the issue and created a PR. This was before you replied to me.
If you'd like you can close the PR, and I can make another identical PR on the 15th :)

@HeyAnirudh HeyAnirudh added the HSOC22-Level-1 5 points label Jul 13, 2022
@HeyAnirudh
Copy link
Owner Author

HeyAnirudh commented Jul 15, 2022

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")
because the way linux organises the file system is a bit different (ie there is no C drive for example).
Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

My apologies, I had some spare time this morning, and unfortunately have already fixed the issue and created a PR. This was before you replied to me. If you'd like you can close the PR, and I can make another identical PR on the 15th :)

yes

could you assign this to me please?

done!

Thank you! I was about to start working on it but before that I noticed that there was a problem with running the app: My computer is running Linux, and as such, when it tries to run the app, it does not find the hard coded values: 'C:\\Users\\Admin\Desktop\\github\\certificates_streamlit\\pics\\apricus.png') and "images\\img.png")
because the way linux organises the file system is a bit different (ie there is no C drive for example).
Before I try and fixing the fonts issue, may I open a separate Pull Request and try changing these hardcoded values using the python OS module, abstracting these hard coded values so that the app runs on Mac OS, Linux,and windows with no problems?

thank you @Beatrix-droid for pointing out the issue, and yes could you open a pull request but not before the 15th.

My apologies, I had some spare time this morning, and unfortunately have already fixed the issue and created a PR. This was before you replied to me. If you'd like you can close the PR, and I can make another identical PR on the 15th :)

hey instead delete the pr and make this an issue and self-appoint it, it would be even better. ill share the format of creating a issue in the discord soon.

HeyAnirudh pushed a commit that referenced this issue Jul 22, 2022
@HeyAnirudh HeyAnirudh added the HSOC22 For participant of HSOC22 label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers HSOC22-Level-1 5 points HSOC22 For participant of HSOC22
Projects
None yet
Development

No branches or pull requests

2 participants