Skip to content
This repository has been archived by the owner on Apr 30, 2023. It is now read-only.

Bug: cancelling login leads to 404 #490

Open
4rgc opened this issue Jul 12, 2021 · 2 comments
Open

Bug: cancelling login leads to 404 #490

4rgc opened this issue Jul 12, 2021 · 2 comments
Labels
bug Something isn't working needs triage An issue or feature request needing triage

Comments

@4rgc
Copy link

4rgc commented Jul 12, 2021

Issue description

If you press cancel on the GitHub OAuth login page, it will redirect you to https://beta.oasis.sh/login and show a 404 screen.

Steps to reproduce the issue

  1. Be logged out.
  2. Press Login on the home page
  3. Press Cancel on the GitHub's OAuth login page.

What's the expected result?

Get redirected to the home page.

What's the actual result?

Get redirected to the login page, and see the 404 error.

Additional details / screenshot

screenshot

@4rgc 4rgc added bug Something isn't working needs triage An issue or feature request needing triage labels Jul 12, 2021
@Simplyalex99
Copy link
Contributor

Simplyalex99 commented Jul 20, 2021

Hello, I was wondering if there was any update on this issue( if it was resolved)?
I believe this is happening because during the Oauth process, if something is unsuccessful the default URL is the 404 page which is correct. So what we can do is add some event listener , or cancel token or something to know when the cancel button is clicked to change the redirected URL to homepage and not 404.

@kelsny
Copy link

kelsny commented Jul 20, 2021

currently we're moving away from the monorepo so maybe it will be fixed in api or web

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs triage An issue or feature request needing triage
Projects
None yet
Development

No branches or pull requests

3 participants