New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Type(V) is object instead of if |V| is any kind of object #222
Comments
Do we also want to change things like this:
to
|
What about:
to:
|
These are equivalent. The ES spec seems to use both. From some brief skimming, it compares against the literal values most of the time, and does Type comparisons when it's part of a series of type comparisons (e.g. compare step 1 and step 8.a in https://tc39.github.io/ecma262/#sec-ordinarysetprototypeof). I'd say not worth messing with unless you see something obviously weird as you go by.
This seems like a good change for slight clarity improvements. I might omit the parenthetical. Unlike the original change that spurred this issue though, it doesn't move us from using an unspecified concept to a specified one, so it's not as important. |
Isn't "native Error object" kinda unspecified? That's not a phrase ECMAScript would use I think. |
Yes, but the parenthetical specifies what is meant precisely. |
See #220 (comment)
The text was updated successfully, but these errors were encountered: