Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialized value should allow any string type #259

Closed
annevk opened this issue Dec 19, 2016 · 3 comments · Fixed by #323
Closed

Serialized value should allow any string type #259

annevk opened this issue Dec 19, 2016 · 3 comments · Fixed by #323
Labels
⌛ duration:short Should be a short fix good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@annevk
Copy link
Member

annevk commented Dec 19, 2016 •
edited

https://heycam.github.io/webidl/#dfn-serialized-value is overly restrictive. All string types convert into a JavaScript string after all at the return boundary.
@tobie tobie added ⌛ duration:short Should be a short fix good first issue Ideal for someone new to a WHATWG standard or software project labels Dec 20, 2016
@tobie
Copy link
Collaborator

tobie commented Dec 22, 2016 •
edited

Yeah. I'm having a hard time figuring out precisely why we need a distinction between serialized values and serializable types.

@bzbarsky
Copy link
Collaborator

Chances are this just wasn't expanded when new string types were added. I see no reason to limit it to DOMString.

@tobie
Copy link
Collaborator

tobie commented Dec 22, 2016 •
edited

@bzbarsky, the serializable types do contain all string types and convert them all to DOMStrings, so I don't think that's an omission.

@tobie tobie mentioned this issue Mar 3, 2017
Merged
tobie added a commit that referenced this issue Jun 21, 2017
@tobie
Replace serializers by toJSON and [Default] extended attribute (#323)
a505f33 
* Remove all serializers.
* Add support for JSON stringification through the toJSON operation.
* Add the [Default] extended attribute.
* Add a default JSON operation.

Fixes #188.
Closes #259.
Fixes #260.
Fixes #262.
Fixes #370.
Closes https://www.w3.org/Bugs/Public/show_bug.cgi?id=27428.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⌛ duration:short Should be a short fix good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace serializers by toJSON and [Default] extended attribute tobie/webidl
3 participants
@tobie @bzbarsky @annevk