Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-to-IDL conversion broken for annotated types #443

Closed
tobie opened this issue Sep 19, 2017 · 2 comments
Closed

ES-to-IDL conversion broken for annotated types #443

tobie opened this issue Sep 19, 2017 · 2 comments

Comments

@tobie
Copy link
Collaborator

tobie commented Sep 19, 2017

As raised by @TimothyGu in #441 (comment):

the union conversion algorithm only really talks about annotated types in the flattened member types algorithm, which just throws away any annotations on the member types of a union type. This means that, technically as of now, ([TreatNullAs=EmptyString] DOMString or SomeObjectType) is equivalent to (DOMString or SomeObjectType) as far as ES-to-IDL conversion is concerned. This does not seem right.
tobie added a commit to tobie/webidl that referenced this issue Sep 19, 2017
@tobie
Add support for annotated types in ES to IDL conversion algorithm
4476cce 
Closes whatwg#443
@tobie tobie mentioned this issue Sep 19, 2017
Closed
tobie added a commit to tobie/webidl that referenced this issue Sep 19, 2017
@tobie
Support annotated types in ES to IDL conversion of union types
6985b7c 
Closes whatwg#443
@tobie
Copy link
Collaborator Author

tobie commented Sep 19, 2017 •
edited

Re-reading this now, it looks like the ES to DOMString and ES to Int algorithms are already handling this by looking at the extended attributes associated with the types.

Closing this as wontfix.

@tobie tobie closed this as completed Sep 19, 2017
@TimothyGu
Copy link
Member

Ah okay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for annotated types in ES to IDL conversion algorithm tobie/webidl
2 participants
@tobie @TimothyGu