New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Reject' definition. #73
Comments
Oh, this went away with platform array objects, looks like. That's bad. |
In particular, in #52 |
Oh, but more to the point, we don't need this thing because in ES6 the contract for @heycam should we just update all out [[DefineOwnProperty]] to the ES6 definition? |
Yes I think we should update. And to me it looks like all [[DefineOwnProperty]] calls in Web IDL currently can just ignore its return value. Do you agree? Apart from http://heycam.github.io/webidl/#defineownproperty which needs to just return it. |
@heycam The calls in dictionary and sequence idl-to-es conversion should never return false. Same thing in the unscopeables setup and serializer bits, So ignoring the return value there makes sense. The call for [Replaceable] attribute setters, however, I think should probably throw if false is returned. Testing this in browsers is a bit of a pain because you can't freeze a Window effectively, but this is a testcase:
Looks to me like this throws in Firefox but not Chrome (which silently ignores the set instead)... Chrome doesn't throw with |
Note that the this was fixed by 8c9b828 |
In https://heycam.github.io/webidl/#named-properties-object-defineownproperty and https://heycam.github.io/webidl/#defineownproperty
The term "Reject" is referring to a non-existent section.
Ex:
The text was updated successfully, but these errors were encountered: