Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify and add examples for "extended attributes associated with" #355

Merged
merged 1 commit into from May 10, 2017

Conversation

domenic
Copy link
Member

@domenic domenic commented Apr 28, 2017

Closes #341.


Preview | Diff

Copy link
Collaborator

@tobie tobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus nits.

index.bs Outdated
};
</pre>

but only if [<code>XAttr</code>] is [=applicable to types=]; otherwise
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lowercase "but" here is a bit weird. Maybe uppercase it or give a tad more context.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, merging

index.bs Outdated
};
</pre>

but only if [<code>XAttr</code>] is [=applicable to types=]; otherwise
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@domenic domenic merged commit 8e43020 into master May 10, 2017
@domenic domenic deleted the clarify-type-xattrs branch May 10, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants