Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and clarify exposed dfn #464

Merged
merged 3 commits into from Dec 19, 2017
Merged

Fix and clarify exposed dfn #464

merged 3 commits into from Dec 19, 2017

Conversation

tobie
Copy link
Collaborator

@tobie tobie commented Oct 17, 2017 •
edited by pr-preview bot

@tobie tobie mentioned this pull request Oct 17, 2017
Closed
domenic
domenic requested changes Oct 17, 2017
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some confusion on |env|, which is a realm (there's an outstanding issue to s/ECMAScript global environment/realm), and |env|'s global, which is an object.

index.bs Outdated
An [=interface=], [=namespace=], or [=member=] |construct| is <dfn id="dfn-exposed" export>exposed</dfn>
in a given ECMAScript global environment |env| if the following steps return true:

1. If |env| does not implement an [=interface=] that is in |construct|'s [=exposure set=],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|env| does not implement interfaces; |env|'s [=realm/global object=] does. This got lost in translation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

index.bs Outdated
then return false.
1. If |construct| is [=available in both secure and non-secure contexts=],
then return true.
1. If the [=relevant settings object=] for |env| is a [=secure context=],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be [=realm/settings object=]

@TimothyGu TimothyGu mentioned this pull request Dec 11, 2017
Merged
@tobie tobie merged commit 860ecf4 into whatwg:master Dec 19, 2017
@tobie tobie deleted the exposed branch December 19, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobie @domenic