Remove definition of class strings of default iterator objects #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per consensus reached in whatwg#483, class strings should only exist on iterator prototype objects.
This was referenced Dec 25, 2017
|
Ping on this. /cc @bzbarsky |
|
Seems OK. I'll let @tobie merge because I don't know what all pieces are in flight right now... |
|
@tobie @bzbarsky Could one of you review web-platform-tests/wpt#8796 as well? |
|
@TimothyGu Looks like @annevk got to that, right? Do you still need my review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per consensus reached in #483, class strings should only exist on iterator prototype objects.
Tests: web-platform-tests/wpt#8796
Preview | Diff