Fix arrays #52
Merged
Fix arrays #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4040,8 +4042,6 @@ dictionary <i>Derived</i> : <em>Base</em> { | |||
| <li>the type is a dictionary that <a class='dfnref' href='#dfn-dictionary-inherit'>inherits</a> from <var>D</var></li> | |||
| <li>the type is a <a class='dfnref' href='#dfn-nullable'>nullable type</a> | |||
| whose <a class='dfnref' href='#dfn-inner-type'>inner type</a> includes <var>D</var></li> | |||
| <li>the type is a <a href='#idl-sequence'>sequence type</a> or <a href='#idl-array'>array type</a> | |||
There was a problem hiding this comment.
Why can the sequence bits here go away? Shouldn't they stay but FrozenArray get added?
There was a problem hiding this comment.
They should indeed stay.
|
Thanks for reviewing. |
heycam
added a commit
that referenced
this pull request
Jul 7, 2015
Fix the array situation by removing the T[] type and adding FrozenArray<T>. This fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=23682.
Closed
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Aug 18, 2017
WebIDL arrays (e.g. "T[] bar") were removed from the spec back in 2015 with whatwg/webidl#52. Previous users should use sequences or FrozenArrays most of the time. Now that all existing WebIDL array users have been fixed, we can finally adapt to the change and remove support for arrays from //tools/idl_parser as well as the bindings layer and related tests. Bug: 740865 Change-Id: I9edfcb7b88963ea92836f7ed93945ad7edd48603 Reviewed-on: https://chromium-review.googlesource.com/616661 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#495108}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bzbarsky can you take a look at this, as a solution to https://www.w3.org/Bugs/Public/show_bug.cgi?id=23682?