Editorial: Avoid changing internal methods of ordinary objects #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Jul 6, 2020
Co-authored-by: Domenic Denicola <d@domenic.me>
domenic
reviewed
Jul 6, 2020
ExE-Boss
force-pushed
the
editorial/interface-prototype-object/avoid-changing-ordinary-object-internal-methods
branch
from
d6407d6
to
2131856
Compare
domenic
approved these changes
Jul 7, 2020
ExE-Boss
deleted the
editorial/interface-prototype-object/avoid-changing-ordinary-object-internal-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up #871, where I missed the fact that interface prototype objects of global objects and objects in the prototype chain of global objects have their
[[SetPrototypeOf]]internal method changed in a way that makes them immutable prototype exotic objects.Changing the
[[SetPrototypeOf]]method of the result ofOrdinaryObjectCreategoes against the intention of separatingOrdinaryObjectCreateandMakeBasicObject, so this fixes that.Preview | Diff