Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot resolve/reject a promise in parallel #953

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Cannot resolve/reject a promise in parallel #953

merged 4 commits into from
Feb 3, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 2, 2021 •
edited by pr-preview bot

@annevk
Copy link
Member Author

annevk commented Feb 2, 2021

@rakuco when sorting your name by last name, what is the sorting key? (I'm not sure why, but IDL seems like it sorts by last name at the moment.)

domenic
domenic reviewed Feb 2, 2021
View reviewed changes
index.bs Show resolved Hide resolved
@annevk annevk requested a review from domenic February 2, 2021 17:56
@rakuco
Copy link
Member

rakuco commented Feb 2, 2021

@rakuco when sorting your name by last name, what is the sorting key? (I'm not sure why, but IDL seems like it sorts by last name at the moment.)

That'd be "Kubo da Costa" -- the whole thing's my last name. I wouldn't personally worry if the sorting works differently though :-)

@annevk annevk merged commit 5abad96 into master Feb 3, 2021
@annevk annevk deleted the annevk/queue-a-task branch February 3, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annevk @rakuco @domenic @TimothyGu