Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

換圖時喝水issue #2

Closed
wow5109 opened this issue May 16, 2021 · 7 comments
Closed

換圖時喝水issue #2

wow5109 opened this issue May 16, 2021 · 7 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@wow5109
Copy link

wow5109 commented May 16, 2021

不是Bug只是想提問,
我在切換圖時,喝水的偵測都會執行,
視窗化切出去再回來也會,
想請問這有辦法調整嗎?
不是太大的問題,只是想詢問看看,

另外喝水的抓座標,
我視窗化後,移動式窗位置,
喝水的座標有需要重設嗎?
謝謝。

@heyfey
Copy link
Owner

heyfey commented May 18, 2021

A1.
我也不知道怎麼解決
現在都是過圖時把自動喝水關掉再打開

A2.
你可以試試看,應該是需要重設的。因為紀錄的座標是相對於整個main monitor
如果你真的很需要的話,我可以測試看看如何解決
但可能會增加CPU的負擔

另外,移動視窗的話,自動撿裝的功能也會受影響
因為目前畫面搜尋範圍是寫死的:

LootBigRegion():

PixelSearch, Px, Py, 100, 100, A_ScreenWidth-10, A_ScreenHeight-150, lootColor, 5, Fast

LootSmallRegion():

PixelSearch, Px, Py, 650, 300, 950, 500, lootColor, 5, Fast

@heyfey heyfey added the question Further information is requested label May 18, 2021
@wow5109
Copy link
Author

wow5109 commented May 19, 2021

@heyfey
A1.
沒關係,我開關也可以
A2.
我目前視窗化移動似乎還沒有太大問題,我再多觀察看看

另外想多提出一個問題,
上方的 2 3 串聯施放,能否也做一個開關,
因為我發現有這兩個我會沒辦法好好打字,
謝謝。

@heyfey heyfey added the enhancement New feature or request label May 19, 2021
@heyfey
Copy link
Owner

heyfey commented May 19, 2021

@heyfey
A1.
沒關係,我開關也可以
A2.
我目前視窗化移動似乎還沒有太大問題,我再多觀察看看

Great!
Seems like I've misunderstood the usage of MouseGetPos. (and PixelSearch)
The coordinates are relative to the active window (i.e. Path of Exile), rather the main monitor.

However, I guess you still need to reset the coordinates when resizes the window.
It would be great if you can test this

另外想多提出一個問題,
上方的 2 3 串聯施放,能否也做一個開關,
因為我發現有這兩個我會沒辦法好好打字,
謝謝。

Sure,
I'll work on that this weekend.

@wow5109
Copy link
Author

wow5109 commented May 22, 2021

@heyfey
切換解析度(或手動resize),的確自動喝水的位置點還是會跑掉,不過這應該還好,重新設定就好。
比較迫切的應該還是2 3 串聯的需要一個開關,不然真的好難打字,
再麻煩你了

heyfey added a commit that referenced this issue May 22, 2021
@heyfey
Copy link
Owner

heyfey commented May 22, 2021

@wow5109

@heyfey
切換解析度(或手動resize),的確自動喝水的位置點還是會跑掉,不過這應該還好,重新設定就好。

Got it, thanks for the testing!

比較迫切的應該還是2 3 串聯的需要一個開關,不然真的好難打字,
再麻煩你了

I've add it in a958f43, please kindly try it :)

@wow5109
Copy link
Author

wow5109 commented May 23, 2021

@heyfey 感謝加上 ctrl+L開關,不過好像有時候會失效

@heyfey heyfey closed this as completed in 8f2f2b1 May 23, 2021
@heyfey
Copy link
Owner

heyfey commented May 23, 2021

@heyfey 感謝加上 ctrl+L開關,不過好像有時候會失效

@wow5109
Thanks for the report!
I've fixed a bug of not turn on hotkey correctly when pressing apply change

Feel free to reopen the issue if still buggy,
or open a new issue for other requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants