Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize skills/spells upon creation. #28

Open
heyitsbench opened this issue Jun 28, 2022 · 5 comments
Open

Reorganize skills/spells upon creation. #28

heyitsbench opened this issue Jun 28, 2022 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@heyitsbench
Copy link
Owner

Currently the racial spells/skills that are being assigned are sorta hackfixed to be given on creation in a way dissimilar to stock races. That's gotta get fixed.

@heyitsbench heyitsbench changed the title Fix skills/spells upon creation. Reorganize skills/spells upon creation. Jun 28, 2022
@heyitsbench heyitsbench added the enhancement New feature or request label Jun 28, 2022
@heyitsbench
Copy link
Owner Author

A bunch of skills still aren't being given when they should, such as 2h axe proficiency for worgen warriors. I believe this is due to DBC discrepancies, as I believe this skill is being adjusted in the DB query. Intention is to retroport/adjust the gear that worgen/goblins start with in Cata and adjust skills loosely based on Cata due to the fact that proficiencies with armors/weapons was changed quite a bit.

@heyitsbench
Copy link
Owner Author

Okay, ported all the gear in 77955b2. https://github.com/benjymansy123/mod-worgoblin/blob/master/sql/world/item_template.sql needs to get fixed quickly, because the armor/one of the stat value columns are swapped I guess I don't know what happened there, but it's required for worgen/goblins to spawn with gear. Very cool. Once the SQL is fixed, then fixing skills is next priority.

@heyitsbench
Copy link
Owner Author

Fixed in d597c40 and moved to worgoblin.sql in 5d791ea. Now to fix skills. As of right now, goblin warriors are missing 2h mace, rogues are missing 1h mace, and worgen rogues are missing 1h axe skill.

@heyitsbench heyitsbench added the bug Something isn't working label Jul 9, 2022
@heyitsbench
Copy link
Owner Author

Reorganized some skills with 2094f4a, e1a7c15, and 12ef986. Going to go through every class combo with worgen/goblins and figure out what I want to be given or learnable and set it up accordingly (and also test every one, which sounds excruciatingly tedious.) As of right now, no race/class combo is being given a piece of gear that they can't wear, so that's some progress at least.

@Alyst3r
Copy link
Contributor

Alyst3r commented Dec 19, 2022

A bunch of skills still aren't being given when they should, such as 2h axe proficiency for worgen warriors.

I believe this may actually be caused by races not being defined in SharedDefines.h but I did not really take my time to recompile after adding them. But what makes me believe this, is a bunch of errors from worldserver.exe
errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants