Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert patch into module #5

Open
Helias opened this issue Mar 6, 2022 · 2 comments
Open

Convert patch into module #5

Helias opened this issue Mar 6, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Helias
Copy link
Collaborator

Helias commented Mar 6, 2022

I don't know if I already told you, but I had the same idea about this, I would like to create a module like mod-race-goblin or mod-race-worgen.

We should convert the patch into a module (may changing the core a bit to be compatible with the module).

@heyitsbench
Copy link
Owner

heyitsbench commented Mar 6, 2022

We should convert the patch into a module (may changing the core a bit to be compatible with the module).

azerothcore/azerothcore-wotlk#7648

To my knowledge there aren't any hooks currently available in AC to be utilized for this yet. If one gets added or if an existing one can serve the same purpose, I'd be more than happy to convert this into a module properly rather than require users to patch their core to use it.

Unfortunately I have no idea how to add a hook myself, nor have I really investigated it much.

@Helias
Copy link
Collaborator Author

Helias commented Mar 7, 2022

We could change the define lists into hashmap as I did here azerothcore/azerothcore-wotlk#1444 and allow to change those hashmap values also from modules.
We could even add some hooks to add them but it's a bit complicated I think

@heyitsbench heyitsbench added enhancement New feature or request help wanted Extra attention is needed labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants