Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search icon in mobile navbar #68

Closed
bigint opened this issue Jul 20, 2022 · 5 comments
Closed

Add search icon in mobile navbar #68

bigint opened this issue Jul 20, 2022 · 5 comments
Assignees
@danschewy

Comments

@bigint
Copy link
Member

bigint commented Jul 20, 2022

No description provided.

@danschewy
Copy link
Contributor

Where would you like the search icon?

@bigint
Copy link
Member Author

bigint commented Jul 25, 2022

Screenshot 2022-07-25 at 1 27 55 PM

Screenshot 2022-07-25 at 1 28 11 PM

@danschewy in the search box in navbar something like twitter does 馃檱馃徎

@shanpriyan
Copy link
Contributor

@bigint can we show search bar inside the header in mobile view? so that we can also show suggestions dropdown list.
image
image

@bigint
Copy link
Member Author

bigint commented Jul 28, 2022

@shanpriyan it looks a bit messy, I think GitHub mobile has a good search bar that lives inside the expanded menu 馃檱馃徎

@shanpriyan shanpriyan self-assigned this Jul 29, 2022
@shanpriyan shanpriyan mentioned this issue Jul 29, 2022
Closed
@shanpriyan shanpriyan assigned danschewy and unassigned shanpriyan Jul 30, 2022
@shanpriyan shanpriyan mentioned this issue Jul 30, 2022
Merged
@bigint bigint closed this as completed Jul 31, 2022
@danschewy danschewy mentioned this issue Jul 31, 2022
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danschewy danschewy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add search icon in search bar
3 participants
@danschewy @shanpriyan @bigint