Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give window a better maximum size #5

Closed
hanaral opened this issue Mar 6, 2021 · 7 comments
Closed

Give window a better maximum size #5

hanaral opened this issue Mar 6, 2021 · 7 comments

Comments

@hanaral
Copy link

hanaral commented Mar 6, 2021

Right now it seems to stretch as far as it likes - you should probably make it scrollable after a certain size, and make the top and bottom of the view fade out with Granite

A bit like this:
Screenshot from 2021-03-06 17-42-55

@hezral
Copy link
Owner

hezral commented Mar 7, 2021

Thanks, can you give a word that makes this behaviour?

It does limit the vertical window size

image

also i was looking into the view fade out, do you happen to know which Granite module that is in?

@hanaral
Copy link
Author

hanaral commented Mar 7, 2021

I can't remember how I managed to do it, it might be because I'm using an older - I'll see if I can reproduce it with the latest.
As for the Granite widget, I looked into it too and it turns out it isn't a set widget. I can't find how they do it on both the applications manu and code in the same way without any mention of a class or anything extra in the css, so it's probably a stylesheet feature.
@cassidyjames Could you drop some hints on how Code, the applications menu and a bunch of other list views have the fade effect?

@hezral
Copy link
Owner

hezral commented Mar 7, 2021

i think it's here https://github.com/elementary/code/blob/master/src/Widgets/FormatBar.vala somewhere :) i'll dig around

@hezral
Copy link
Owner

hezral commented Mar 7, 2021

couldn't find it, maybe its done via the stylesheet in Odin.

@hezral
Copy link
Owner

hezral commented Oct 20, 2021

Fixed in new release elementary/appcenter-reviews#172

@hezral hezral closed this as completed Oct 20, 2021
@cassidyjames
Copy link

@hezral yep to confirm the fade out is handled in the stylesheet, currently only targeting popovers since we can be more sure what the background color is. But I'd be open to explicitly adding it with a style class, that could be handy.

@hezral
Copy link
Owner

hezral commented Oct 21, 2021

thanks, i found it actually in the stylesheet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants