Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reported buffer overflows #287

Closed
loveshack opened this issue Nov 26, 2018 · 7 comments
Closed

reported buffer overflows #287

loveshack opened this issue Nov 26, 2018 · 7 comments
Assignees

Comments

@loveshack
Copy link

The following reports of asan errors in the generator were made in the Fedora tracker, but apparently against development source, not a version in Fedora, and it's not clear exactly how they're obtained. You may want to take a look anyhow. I haven't examined them other than to verify they don't match the v1.9 source which is currently in Fedora.
(I'll update the packaging to 1.10 now I know about it; Fedora release notification is broken, unfortunately.)

https://bugzilla.redhat.com/show_bug.cgi?id=1652632
https://bugzilla.redhat.com/show_bug.cgi?id=1652633
https://bugzilla.redhat.com/show_bug.cgi?id=1652635

@hfp hfp self-assigned this Nov 26, 2018
@hfp
Copy link
Collaborator

hfp commented Nov 26, 2018

Thank you very much, I will look into this!

I missed these three issues although I am somewhat watching if there are [major] complaints raised by the RPM, Debian, and FreeBSD packages.

@hfp
Copy link
Collaborator

hfp commented Nov 26, 2018

For our own reference, the data attached to the original bug reports seems to be malformed (.txt file-extension was appended to suit GitHub's need for a supported file-type).

POC0.txt
POC1.txt
POC3.txt

@loveshack
Copy link
Author

loveshack commented Nov 26, 2018 via email

@hfp
Copy link
Collaborator

hfp commented Dec 2, 2018

The reported issues had the same root cause, which is fixed in GitHub/master (part of the next release update). The issues arised from fuzzed input data (perhaps generated automatically), which is nevertheless malformed CSC input. LIBXSMM's CSC/CSR readers now bail out with an error (previously: undefined behaviour).

TODO: the issue is kept open until Valgrind (and similar tools) confirm no issues.

hfp added a commit that referenced this issue Jan 2, 2019
…by generate an eventual error message. Library initialization is needed for verbosity (warnings/errors). Added VC project for NOBLAS (dummy-)library. Adjusted error message (90011). Code cleanup.
@hfp
Copy link
Collaborator

hfp commented Jan 2, 2019

The reported issues are fixed in LIBXSMM's master revision. There was no real application for the reported cases as invalid input data was supplied to a low-level API function. Beside of checking the input, an error message is generated.

@hfp hfp closed this as completed Jan 2, 2019
@hfp
Copy link
Collaborator

hfp commented Oct 27, 2019

As stated above, the issues appeared to be discovered automatically using an approach fuzzing input data to induce a problem. The related publications can be found https://www.usenix.org/system/files/sec20spring_gan_prepub.pdf.

The way of reporting the problem(s) is borderline (opinion) as the authors reported findings upstream as a security hole of the library for the matter of claiming three CVEs (instead of one). The latter got replicated allover the Internet (several other bug trackers).

@loveshack loveshack mentioned this issue Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants