Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Webpack 5 #81

Closed
mo4islona opened this issue Dec 21, 2020 · 3 comments
Closed

Support Webpack 5 #81

mo4islona opened this issue Dec 21, 2020 · 3 comments
Assignees
@hg-pyun
Labels
dependencies Pull requests that update a dependency file

Comments

@mo4islona
Copy link

mo4islona commented Dec 21, 2020 •
edited
Loading

Webpack 5 has no longer NodeJs polyfills
https://webpack.js.org/migrate/5/#test-webpack-5-compatibility

There is no error building with Webpack 4 but it crashes with Webpack 5 because of chalk dependency

vendors.js:53270 Uncaught ReferenceError: process is not defined
    at Object.../../node_modules/axios-logger/node_modules/chalk/index.js (vendors.js:53270)
    at __webpack_require__ (runtime.js:22)
    at Object.../../node_modules/axios-logger/lib/common/string-builder.js (vendors.js:52803)
    at __webpack_require__ (runtime.js:22)
    at Object.../../node_modules/axios-logger/lib/logger/request.js (vendors.js:53007)
    at __webpack_require__ (runtime.js:22)
    at Object.../../node_modules/axios-logger/lib/index.js (vendors.js:52926)
    at __webpack_require__ (runtime.js:22)
    at Module.../shared/src/api/axios.ts (main.js:22861)
    at __webpack_require__ (runtime.js:22)

I guess latest version of chalk doesnt use process.platform anymore.
Maybe it is time to update it? :)
@hg-pyun
Copy link
Owner

hg-pyun commented Dec 22, 2020

@mo4islona Thank you for report. I will update it.

@hg-pyun hg-pyun self-assigned this Dec 22, 2020
@hg-pyun hg-pyun added the dependencies Pull requests that update a dependency file label Dec 22, 2020
@hg-pyun
Copy link
Owner

hg-pyun commented Dec 23, 2020

@mo4islona https://github.com/hg-pyun/axios-logger/blob/master/package.json#L52 Updated to chalk@4.1.0

@mo4islona
Copy link
Author

Tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hg-pyun hg-pyun

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mo4islona @hg-pyun