Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: prop for pop-up card #18

Open
awatson1978 opened this issue Dec 8, 2020 · 0 comments
Open

Feature Request: prop for pop-up card #18

awatson1978 opened this issue Dec 8, 2020 · 0 comments

Comments

@awatson1978
Copy link

Current designs call for a pop-up or overlay card, that can inspect contents of a data point on hGraph.

Screen Shot 2020-12-08 at 11 53 01 AM

It would be ideal to be able to feed in an external React component via a prop. Possible API might look like the following:

          <HGraph
            data={ data.currentData }
            width={ graphSize }
            height={ graphSize }
            healthyRangeFillColor={themePrimaryColor}
            showScore={ false }
            margin={{ top: 140, right: 72, bottom: 140, left: 72 }}      
            popUpPosition={['bottom', 'right']} // auto?
            popUpComponent={<SimplePopUp theme="dark" />}
          /> 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant