Properly handle offset units for trapz #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgrecco
reviewed
Apr 26, 2023
|
@hgrecco Are you ok with the general approach? |
|
@dopplershift I do! |
|
Ok, I can fix up and implement |
|
Do it in the same PR! |
dopplershift
force-pushed
the
fix-trapz-temp
branch
from
194b084
to
6977fe6
Compare
dopplershift
force-pushed
the
fix-trapz-temp
branch
from
6977fe6
to
819f920
Compare
|
The test failures look unrelated to my changes. Those tests fail for me locally on the master branch as well. |
|
Indeed, this is related to #1505 I will fix it and then review and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an attempt to fix #1593. Fixing it is made complicated since the general multiplication handling in
numpy_func.pyis used for e.g.a = 5 * units.degC. The easiest way to fix it seemed then to be to just directly implement a wrapper fortrapz. If this approach is acceptable, then I can also implement fixes forcrossanddot.pre-commit run --all-fileswith no errors