Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions confusion #11

Closed
ArsSirek opened this issue Apr 2, 2018 · 1 comment
Closed

Versions confusion #11

ArsSirek opened this issue Apr 2, 2018 · 1 comment

Comments

@ArsSirek
Copy link
Contributor

ArsSirek commented Apr 2, 2018

Hi @hguenot , thanks for the work on this project,
I am a bit confused with versions here, I started to use the project a year ago, and tried to update the system to work with php 7.2 now, There was an issue with the Object class name, but the actual problem for me turned out to be that composer doesn't update this repository automatically.

the error I received:

PHP Fatal error: Declaration of
gftp\drivers\SftpDriver::get($remote_file, $local_file = NULL, $mode = gftp\drivers\FTP_ASCII, $asynchronous = false)
must be compatible with
gftp\drivers\RemoteDriver::get($remote_file, $local_file = NULL, $mode = gftp\drivers\FTP_ASCII, $asynchronous = false, ?callable $asyncFn = NULL)
in ../vendor/hguenot/yii2-gsftp/drivers/SftpDriver.php on line 15

I see that the code on the github was updated with the commit
But can't get composer to see that.. which is probably an issue to composer, but I decided to post it here as I may be not the only one with the issue, it is fine with you, right?

It worked only after I run an update with commit version

composer require hguenot/yii2-gsftp dev-master#d2d22ac70df744daf3bcee596a7641ac82aa4122

But is there any other, recommended, way to update I missed?

@hguenot
Copy link
Owner

hguenot commented Apr 2, 2018

Hi @ArsSirek

I've just created the release V1.1.2.
Have you try to use a released version instead of master branch in your composer ?

Maybe deleting entry in composer.lock file (or deleting this file) and running composer update could work...

HG

@hguenot hguenot closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants