speedup #3
Closed
speedup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making image a thumbnail before analyzing makes the analysis part of the code run in constant time since all images are now 200x200 instead of 1400x2000 or 3600x4800 or whatever on the small test images, 10x speedup, on larger 1000x1000 images, 30x+ speedup using thumbnail smaller than ~200x200 starts affecting results (not passing some tests etc)
|
Thanks for suggestion. This change cannot be marged. original $ python testnude.py
(False, u"#<nude.Nude:0x105527110('./images/damita.jpg' 'JPEG' '500x375'): result=False message='Total skin parcentage lower than 15 (7.692%)'>")
(False, u"#<nude.Nude:0x10586f990('./images/damita2.jpg' 'JPEG' '500x375'): result=False message='Total skin parcentage lower than 15 (10.047%)'>")
(False, u"#<nude.Nude:0x105527110('./images/test6.jpg' 'JPEG' '500x375'): result=False message='Less than 3 skin regions (1)'>")
(True, u"#<nude.Nude:0x10586fc10('./images/test2.jpg' 'JPEG' '500x375'): result=True message='Nude!!'>")your PR $ python testnude.py
(False, u"#<nude.Nude:0x10ef29110('./images/damita.jpg' 'JPEG' '200x150'): result=False message='Less than 3 skin regions (1)'>")
(False, u"#<nude.Nude:0x10f272fd0('./images/damita2.jpg' 'JPEG' '200x150'): result=False message='Total skin parcentage lower than 15 (9.420%)'>")
(False, u"#<nude.Nude:0x10ef29110('./images/test6.jpg' 'JPEG' '200x150'): result=False message='Less than 3 skin regions (2)'>")
(True, u"#<nude.Nude:0x10f272f90('./images/test2.jpg' 'JPEG' '200x150'): result=True message='Nude!!'>")sorry, my broken english. |
|
see #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make image a thumbnail first for speed, speedup increases with image resolution (since we're converting to approximately constant time); 10x speedup on the small test images, 30x+ on larger images