Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server only works with a single network interface #6

Open
respectTheCode opened this issue Apr 14, 2018 · 4 comments · May be fixed by #7
Open

Server only works with a single network interface #6

respectTheCode opened this issue Apr 14, 2018 · 4 comments · May be fixed by #7
Assignees
@hhromic
Labels
enhancement

Comments

@respectTheCode
Copy link

When running on a machine with multiple network interfaces only the primary interface works. Im my use case sACN is on an isolated network. This can be fixed by specifying the IP of the desired interface when calling _socket.addMembership.

As a work around I am calling

dmx.on("listening", function() {
    const multicastGroup = "239.255." + (universe >> 8) + "." + (universe & 0xff);
    dmx._socket.addMembership(multicastGroup, dmxInterfaceIP);
@hhromic
Copy link
Owner

hhromic commented Apr 16, 2018

Hi, thanks for reporting!
Indeed I didn't consider multiple interfaces in the original implementation.
Thanks for providing a suggestion, I will try to incorporate it as soon as possible.

@hhromic hhromic self-assigned this Apr 16, 2018
@respectTheCode respectTheCode linked a pull request Jul 2, 2018 that will close this issue
Open
@TimoteusRuotsalainen
Copy link

Any chance in getting this pull request and #21 combined and merged into the project? I can help with the pull request but need to know will it be merged?

@hhromic
Copy link
Owner

hhromic commented Dec 19, 2022

Wow, I completely forgot about this project for several years. I deeply apologise for not coming back to it.
Let me check the pending PRs and start merging.

@hhromic hhromic mentioned this issue Dec 19, 2022
Open
@TimoteusRuotsalainen
Copy link

@respectTheCode I created a pull request that includes this functionality. Are you still using this library?
#22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hhromic hhromic

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add option to specify the network interface ip respectTheCode/e131-node
3 participants
@respectTheCode @hhromic @TimoteusRuotsalainen