Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.18.2 backport? #3

Closed
LordHungry opened this issue Aug 10, 2022 · 4 comments
Closed

1.18.2 backport? #3

LordHungry opened this issue Aug 10, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@LordHungry
Copy link

I'm not sure how much work it would be to backport it to 1.18.2, if it isn't much would it be possible?

I tried to backport it myself but Text.translatable and Allays aren't in the 1.18.2 quilt version from what I can see. Removing the tooltip function and AllayEntityMixin removed all the compiling errors but the game would crash on launch due to registry errors; not too much of a coder so that's as far as I got.
@hibiii hibiii added the help wanted Extra attention is needed label Aug 10, 2022
@LordHungry
Copy link
Author

Nevermind about the registry errors I just get them when I build the jar file even for the regular version, I haven't used java in a hot minute so I might be doing something wrong lol

@LordHungry
Copy link
Author

nvm abt it i just backported it i was being dumb ill open a PR incase you want it

@hibiii hibiii closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
@hibiii hibiii reopened this Aug 12, 2022
@JieningYu
Copy link

It should be finished as the 1.18.2 version is compilable now.

@hibiii
Copy link
Owner

hibiii commented Sep 11, 2022

what 1.18.2 version? there's code for it right now but i haven't released it as a jar

@hibiii hibiii closed this as completed Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LordHungry @JieningYu @hibiii