Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the implementation of optimizers #25

Closed
ghost opened this issue Jul 15, 2018 · 1 comment
Closed

Questions about the implementation of optimizers #25

ghost opened this issue Jul 15, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 15, 2018

  1. For example, in function rmsprop(), suppose sample_idx is None currently , the SharedVariable acc is defined first, followed by acc_new, then set updates[acc] = acc_new, but when calling RMSprop() next time which is not rmsprop(), for a same parameter, in function rmsprop() which is called by RMSprop(), the acc is reset first, then acc_new is computed. Shouldn't SharedVariable acc be defined first in init() function ?
  2. Why using self.lmbd in parameter updating? Like line 387 in file gru4rec.py.
    updates[p] = p * np.float32(1.0 - self.learning_rate * self.lmbd) - np.float32(self.learning_rate) * g
@ghost
Copy link
Author

ghost commented Jul 26, 2018

Resolved.

@ghost ghost closed this as completed Jul 26, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants