We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
based on the current documentation, it should be possible to fetch an ad via BillboardViewModel like this:
BillboardViewModel
let newAdvert = try? await viewModel.fetchRandomAd() advertisement = newAdvert
but there are two difference to what is actually implemented in code:
fetchRandomAd
current workaround:
guard let adsURL = BillboardConfiguration().adsJSONURL else { return } Task { try await BillboardViewModel.fetchRandomAd(from: adsURL) }
a good solution would be to merge showAdvertisement and fetchRandomAd somehow. what would you say to this?
showAdvertisement
The text was updated successfully, but these errors were encountered:
Task { try await BillboardViewModel.fetchRandomAd(from: adsURL) }
Should now work :) thanks for letting me know
Sorry, something went wrong.
okay, if this is the way it should work and documentation will be updated, this issue can be closed I think :)
I'm sorry I mean it works without the URL now :)
No branches or pull requests
based on the current documentation, it should be possible to fetch an ad via
BillboardViewModel
like this:but there are two difference to what is actually implemented in code:
fetchRandomAd
needs an URL parameterfetchRandomAd
is staticcurrent workaround:
a good solution would be to merge
showAdvertisement
andfetchRandomAd
somehow. what would you say to this?The text was updated successfully, but these errors were encountered: