Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Notification Settings feature to Jetpack Compose #175

Closed
hieuwu opened this issue Sep 30, 2023 · 3 comments · Fixed by #188
Closed

Migrate Notification Settings feature to Jetpack Compose #175

hieuwu opened this issue Sep 30, 2023 · 3 comments · Fixed by #188
Labels
good first issue Good for newcomers hacktoberfest

Comments

@hieuwu
Copy link
Owner

hieuwu commented Sep 30, 2023

Currently feature Account in presentation/notificationsettings package is implemented with XML view system. Let's convert it to Jetpack Compose. See shop feature for reference
@Yashraj254
Copy link
Contributor

can i work on this issue?

@hieuwu
Copy link
Owner Author

hieuwu commented Oct 3, 2023

can i work on this issue?

Sure! Go with it Yash. Let me know if you need any support

@yopilot
Copy link
Contributor

yopilot commented Oct 3, 2023

May I also try?

@yopilot yopilot mentioned this issue Oct 3, 2023
Merged
@Yashraj254 Yashraj254 mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest
Projects
Groceries Store
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrated NotificationSettings fragment to NotificationSettingsScreen Composable
3 participants
@hieuwu @Yashraj254 @yopilot