Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash-swap] Repay the 0.3% Uniswap V2 in USDC #62

Closed
scorpion9979 opened this issue Oct 25, 2021 · 1 comment
Closed

[flash-swap] Repay the 0.3% Uniswap V2 in USDC #62

scorpion9979 opened this issue Oct 25, 2021 · 1 comment
Labels
enhancement Improvement for an existing feature or system package:flash-swap

Comments

@scorpion9979
Copy link
Contributor

An implication of #60 being merged is that the flash-swap contract will have to contain collateral tokens to ensure it's able to pay the 0.3% Uniswap fee in some edge cases where the entire liquidated collateral is not enough to repay the flash swap. Instead of having the flash-swap contain multiple token balances, it would be better to only contain the token shared by all pairs, which is the underlying (USDC), and use it to pay the swap fee when those edge cases are met. This would make liquidation a lot easier to manage.

@PaulRBerg
Copy link
Contributor

This has been addressed in #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for an existing feature or system package:flash-swap
Projects
None yet
Development

No branches or pull requests

2 participants