Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protocol] Reduce gas costs via unchecked arithmetic #9

Closed
PaulRBerg opened this issue May 27, 2021 · 1 comment
Closed

[protocol] Reduce gas costs via unchecked arithmetic #9

PaulRBerg opened this issue May 27, 2021 · 1 comment
Labels
enhancement Improvement for an existing feature or system package:protocol stale Not going to implement soon

Comments

@PaulRBerg
Copy link
Contributor

Because of two reasons:

  1. Checking for {over,under}flow is cheaper.
  2. Certiain operations like modulo are cheaper
@PaulRBerg PaulRBerg transferred this issue from hifi-finance/hifi-protocol Aug 9, 2021
@PaulRBerg PaulRBerg changed the title Reduce gas costs via unchecked arithmetic [protocol] Reduce gas costs via unchecked arithmetic Aug 9, 2021
@PaulRBerg PaulRBerg added enhancement Improvement for an existing feature or system package:protocol labels Aug 9, 2021
@PaulRBerg PaulRBerg added the stale Not going to implement soon label Oct 5, 2021
@PaulRBerg
Copy link
Contributor Author

I will close this issue because it's vague and we added lots of unchecked blocks in the meantime. If there is an opportunity to save some gas somewhere, we could open a specific GitHub issue to track that optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement for an existing feature or system package:protocol stale Not going to implement soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg