Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom of apt-daily timers apt-daily-upgrade #85

Closed
mabed-fr opened this issue Jan 20, 2023 · 4 comments · Fixed by #120 or #121
Closed

Added custom of apt-daily timers apt-daily-upgrade #85

mabed-fr opened this issue Jan 20, 2023 · 4 comments · Fixed by #120 or #121
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mabed-fr
Copy link
Contributor

mabed-fr commented Jan 20, 2023

Hello

It seems to me that an important feature is missing.

  • The feature of being able to decide when to DOWNLOAD updates ( apt-daily.timer)
  • The feature of being able to decide when to INSTALL updates (apt-daily-upgrade.timer)

This happens in the following systemd timers

mabed@mabed ~ → systemctl list-timers | grep apt 
Fri 2023-01-20 12:34:48 CET 7min left      Fri 2023-01-20 06:08:39 CET 6h ago       apt-daily.timer              apt-daily.service
Fri 2023-01-20 13:08:27 CET 40min left     Fri 2023-01-20 07:09:38 CET 5h 18min ago apt-daily-upgrade.timer      apt-daily-upgrade.service

I don't know their default value because I modify them on my servers

There is no role but an ansible collection that we can add to this role.

*ansible.builtin.systemd

What do you think?

I will start working on the PR

Mathieu

@mabed-fr
Copy link
Contributor Author

mabed-fr commented Jan 20, 2023

My work is ready but I cannot submit PR

|add-custom-timers--85 ✗|→ yamllint .yamllint 
|add-custom-timers--85 ✗|→ echo $?
0
|add-custom-timers--85 ✗|→ ansible-lint 
Passed with production profile: 0 failure(s), 0 warning(s) on 31 files.
|add-custom-timers--85 ✗|→ echo $?
0

@Normo
Copy link
Member

Normo commented Jan 20, 2023

Thank you @mabed-fr. Is it possible for you to fork the project and submit a PR? If not, what is the error message?

@mabed-fr
Copy link
Contributor Author

mabed-fr commented Jan 21, 2023

Hello @Normo ,

With pleasure but why forked?

This complicates the contribution can you allow me a PR?

Mabed

@Normo Normo linked a pull request Jan 23, 2023 that will close this issue
@mabed-fr
Copy link
Contributor Author

I don't have time to follow your pipeline, if you want to integrate this essential functionality I'll let you correct the pipeline.

Good for you

@Normo Normo added this to the v3.1.0 milestone Jun 5, 2023
@Normo Normo added the enhancement New feature or request label Jun 5, 2023
@Normo Normo self-assigned this Jun 5, 2023
@Normo Normo linked a pull request Jun 5, 2023 that will close this issue
@Normo Normo closed this as completed in #120 Jun 6, 2023
@Normo Normo linked a pull request Jun 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment