Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase all unattended-upgrades options first #107

Merged

Conversation

Normo
Copy link
Member

@Normo Normo commented May 12, 2023

This MR adds a #clear section at the top of the configuration template in order to delete first all relevant unattended-upgrade options that may have been set in other configuration files.

Fixes #94

@Normo Normo force-pushed the 94-apt-options-are-not-overridden-but-merged branch 4 times, most recently from 344ac1a to c3d739c Compare May 12, 2023 13:17
@Normo Normo marked this pull request as ready for review May 12, 2023 13:17
@Normo Normo requested a review from a team as a code owner May 12, 2023 13:17
@tobiashuste tobiashuste self-requested a review May 15, 2023 09:04
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Normo. This looks very reasonable and like a good approach 👍

I only had one question :)

vars/main.yml Show resolved Hide resolved
@tobiashuste tobiashuste self-requested a review May 15, 2023 10:39
Copy link
Member

@tobiashuste tobiashuste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Norman Ziegner added 2 commits May 15, 2023 12:48
Closes hifis-net#94

Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
@Normo Normo force-pushed the 94-apt-options-are-not-overridden-but-merged branch from c3d739c to cc46c87 Compare May 15, 2023 10:48
@Normo Normo merged commit e8124f3 into hifis-net:main May 15, 2023
7 checks passed
@Normo Normo deleted the 94-apt-options-are-not-overridden-but-merged branch June 9, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apt options are not overridden but merged
2 participants