-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the role via molecule and update supported OS #9
Conversation
* Manage dependencies via pipenv * Run Molecule via GitHub Actions
Define the supported platforms according to the CI pipeline. Remove support for OS that are outdated and no longer supported.
@Normo I would be happy if you could have a look. This implements basic role testing via molecule. There is no verification step implemented yet. It simply takes the default installation and deploys it in one of the container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @tobiashuste for implementing this! 🤩 Very much appreciate the effort. I've added some comments/suggestions.
@tobiashuste We can take inspiration for the verfication step from the test play in tests/test.yml |
@Normo I implemented the verification step according to the existing tests. I also changed your other suggestions. So far I did not touch the branch name to wait for your feedback. |
The implementation is inspired upon the existing tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tobiashuste LGTM 👍
Closes #8