Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the role via molecule and update supported OS #9

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Test the role via molecule and update supported OS #9

merged 4 commits into from
Aug 18, 2022

Conversation

tobiashuste
Copy link
Member

@tobiashuste tobiashuste commented Aug 16, 2022

  • Manage dependencies via pipenv
  • Run Molecule via GitHub Actions
  • Update the list of support OS

Closes #8

* Manage dependencies via pipenv
* Run Molecule via GitHub Actions
Define the supported platforms according to the CI pipeline. Remove
support for OS that are outdated and no longer supported.
@tobiashuste tobiashuste marked this pull request as ready for review August 16, 2022 13:28
@tobiashuste tobiashuste requested a review from Normo August 16, 2022 13:29
@tobiashuste
Copy link
Member Author

@Normo I would be happy if you could have a look. This implements basic role testing via molecule. There is no verification step implemented yet. It simply takes the default installation and deploys it in one of the container.

@Normo Normo added this to the v2.0.0 milestone Aug 17, 2022
Copy link
Member

@Normo Normo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @tobiashuste for implementing this! 🤩 Very much appreciate the effort. I've added some comments/suggestions.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
molecule/default/converge.yml Outdated Show resolved Hide resolved
molecule/default/prepare.yml Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
@Normo
Copy link
Member

Normo commented Aug 18, 2022

@tobiashuste We can take inspiration for the verfication step from the test play in tests/test.yml

@tobiashuste
Copy link
Member Author

@tobiashuste We can take inspiration for the verfication step from the test play in tests/test.yml

@Normo I implemented the verification step according to the existing tests. I also changed your other suggestions.

So far I did not touch the branch name to wait for your feedback.

@tobiashuste tobiashuste changed the title Test the role via molecule Test the role via molecule and update support OS Aug 18, 2022
@tobiashuste tobiashuste changed the title Test the role via molecule and update support OS Test the role via molecule and update supported OS Aug 18, 2022
@tobiashuste tobiashuste requested a review from Normo August 18, 2022 06:03
The implementation is inspired upon the existing tests.
Copy link
Member

@Normo Normo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tobiashuste LGTM 👍

@Normo Normo merged commit 94772bf into hifis-net:master Aug 18, 2022
@tobiashuste tobiashuste deleted the molecule-setup branch August 18, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test role via Molecule
2 participants