Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler not working with highcharts 8.0.0 #13

Closed
afont1991 opened this issue Dec 12, 2019 · 2 comments
Closed

Assembler not working with highcharts 8.0.0 #13

afont1991 opened this issue Dec 12, 2019 · 2 comments

Comments

@afont1991
Copy link

afont1991 commented Dec 12, 2019

I am attempting to use the highcharts assembler to create a custom bundle. I have noticed it does not work when used as explained in the documents with the newly released version 8.0.0 of highcharts.

When following the example provided here: https://www.highcharts.com/docs/getting-started/how-to-create-custom-highcharts-files I get the following error:

TypeError: Cannot read property 'includes' of null
    at searchCapture (/home/andrew/Code/highcharts-master/node_modules/highcharts-assembler/src/dependencies.js:161:18)
    at getModuleName (/home/andrew/Code/highcharts-master/node_modules/highcharts-assembler/src/dependencies.js:226:5)
    at compileFile (/home/andrew/Code/highcharts-master/node_modules/highcharts-assembler/src/dependencies.js:565:18)
    at getIndividualOptions.forEach (/home/andrew/Code/highcharts-master/node_modules/highcharts-assembler/src/build.js:179:20)
    at Array.forEach (<anonymous>)
    at build (/home/andrew/Code/highcharts-master/node_modules/highcharts-assembler/src/build.js:178:8)
    at Object.<anonymous> (/home/andrew/Code/highcharts-master/custom-line-builder.js:7:1)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)

I was able to run my code successfully when downgrading to 7.2.1 , but my team would like to use 8.0.0

@bre1470
Copy link
Contributor

bre1470 commented Jan 7, 2020

Hello @afont1991! Thank you for reporting the issue. We will look into it.

@bre1470 bre1470 self-assigned this Jan 7, 2020
@bre1470
Copy link
Contributor

bre1470 commented Jan 7, 2020

Unfortunately I can not reproduce the issue. Which commits do you use for highcharts and highcharts-assembler? How does your custom builder looks like?

@bre1470 bre1470 removed their assignment May 5, 2020
@bre1470 bre1470 closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants