Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xAxis breaks make OHLC/CandleStick series overlap. #16368

Closed
stenTT opened this issue Sep 20, 2021 · 4 comments · Fixed by #19354
Closed

xAxis breaks make OHLC/CandleStick series overlap. #16368

stenTT opened this issue Sep 20, 2021 · 4 comments · Fixed by #19354

Comments

@stenTT
Copy link

stenTT commented Sep 20, 2021

Expected behaviour

No overlapping of individual candlesticks/ohlc points.

Actual behaviour

OHLC or CandeStick seriespoints are overlapping when making use of xAxis breaks to skip weekends.

Live demo with steps to reproduce

https://jsfiddle.net/stenTT/Lxa0pmvo/25/

Uncomment the xAxis breaks in this jsfiddle to get the series to overlap.

Product version

Highstock JS v9.2.2 (2021-08-24)

Affected browser(s)

Firefox

@highsoft-bot highsoft-bot added this to To do in Development-Flow via automation Sep 20, 2021
@KacperMadej
Copy link

Hi @stenTT

Thank you for reporting the problem.

Internal note:
Looks like even just the presence of the breaks option is changing how series and axis are rendered.
Demo with two charts diffing only with having or not the option (breaks) set: https://jsfiddle.net/BlackLabel/L7w49qn1/

@pawelfus
Copy link
Contributor

pawelfus commented Sep 21, 2021

Broken since v5.0.7. Most likely related issue: #5979 (this needs a bisect)

The same as in #5979, Highcharts + broken-axis works fine, which suggests Ordinal involvement

Edit: Issue is not limited to OHLC only, the same with Column type: https://jsfiddle.net/BlackLabel/L7w49qn1/2/

@raf18seb
Copy link
Contributor

raf18seb commented Oct 7, 2021

It was broken before v5.0.7 too (different width, but still broken), so it looks like it's always been broken. Unable to bisect version <5.

Debug could be started in the beforeSetTickPositions method or by searching for a hasBreaks flag.

@krp12345
Copy link

This is demanding fix for my application. It would be great if it fixed in near future.

@pawelfus pawelfus moved this from To do to Inbox in Development-Flow Jul 11, 2023
@kamil-musialowski kamil-musialowski self-assigned this Jul 12, 2023
Development-Flow automation moved this from Inbox to Done Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

7 participants