Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved ZoomComponent. #17452

Merged
merged 2 commits into from Jul 4, 2022
Merged

Improved ZoomComponent. #17452

merged 2 commits into from Jul 4, 2022

Conversation

bre1470
Copy link
Contributor

@bre1470 bre1470 commented Jun 29, 2022 •
edited

  • Removed AxisComposition of ZoomComponent
  • Simplified forEach calls

@bre1470 bre1470 self-assigned this Jun 29, 2022
@highsoft-bot
Copy link
Collaborator

File size comparison

Sizes for compiled+gzipped (bold) and compiled files.

master candidate difference
modules/accessibility.js 35.2 kB
127.1 kB		 35.0 kB
126.9 kB		 -177 B
-233 B

@highsoft-bot
Copy link
Collaborator

Visual test results - No difference found

@bre1470 bre1470 marked this pull request as ready for review June 29, 2022 10:52
TorsteinHonsi
TorsteinHonsi approved these changes Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@TorsteinHonsi TorsteinHonsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TorsteinHonsi TorsteinHonsi merged commit a5c7b42 into master Jul 4, 2022
@TorsteinHonsi TorsteinHonsi deleted the ts/a11y-zoomcomponent branch July 4, 2022 08:01
@bre1470 bre1470 added this to the v10.2.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorsteinHonsi TorsteinHonsi TorsteinHonsi approved these changes

Assignees

@bre1470 bre1470

Labels
None yet
Projects
None yet
Milestone
v10.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bre1470 @highsoft-bot @TorsteinHonsi