Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchscreen devices could not end drawing, select nor edit the drawings (eg. Rectangle, Fibonacci etc.) #18276

Closed
jackytanjq opened this issue Jan 11, 2023 · 3 comments · Fixed by #18515

Comments

@jackytanjq
Copy link

Expected behaviour

The drawing's (eg. Rectangle) second step/point could not be plotted and therefore could not end while using the Safari browser.

Using the Google Chrome browser can complete the drawing, but the drawing could not be selected to edit the points nor the options to edit/delete.

Actual behaviour

The drawings should behave the same as when using a mouse and keyboard.
Each step/point to end on each tap should behave similarly to a mouse click.

Live demo with steps to reproduce

https://www.highcharts.com/demo/stock/stock-tools-gui
Draw a "Rectangle", then single tap on the drawn rectangle to attempt to select.
Highcharts was not able to pick up the single taps to select the drawings.

Product version

Highcharts Stock v10.3.2

Affected browser(s)

Safari and Chrome on touchscreen devices (Tested on iPadOS 15.7, iPad Air 4th Gen and also on Android)

@highsoft-bot highsoft-bot added this to To do in Development-Flow via automation Jan 11, 2023
@bm64
Copy link
Member

bm64 commented Jan 12, 2023

Hello @jackytanjq and thanks for reporting the bug. It looks like it's broken since 9.1.0, in v9.0.1 works fine.

@pawellysy
Copy link
Member

Hello @jackytanjq, thanks for your patience. Here is the workaround for this bug: https://jsfiddle.net/BlackLabel/1g685f2h/4/

Internal note

The SVGElement.prototype.on function got refactored and doesn't implement the unique event behavior for touch events.

@pawellysy
Copy link
Member

Regression after: #15627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants