Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rounded corners in pyramid charts #18839

Closed
bcmrcool opened this issue Apr 17, 2023 · 7 comments · Fixed by #18979
Closed

Allow rounded corners in pyramid charts #18839

bcmrcool opened this issue Apr 17, 2023 · 7 comments · Fixed by #18979
Assignees
Labels
Status: Has workaround Type: Feature Request Used when a new feature is requested either directly or indirectly

Comments

@bcmrcool
Copy link

bcmrcool commented Apr 17, 2023

Description of the feature

We'd like to have rounded corners in highchart's pyramid chart as in the following image:

Screen Shot 2023-04-17 at 3 41 59 PM

It currently looks like:
Screen Shot 2023-04-17 at 3 43 18 PM

I've looked around and reached out to support to no avail.

Library related to the feature

Highcharts

Proof of Concept/Live example for the feature

Screen Shot 2023-04-17 at 3 41 59 PM


You can vote for this feature by adding a thumbs-up reaction to this post.

@bcmrcool bcmrcool added the Type: Feature Request Used when a new feature is requested either directly or indirectly label Apr 17, 2023
@highsoft-bot highsoft-bot added this to To do in Development-Flow via automation Apr 17, 2023
@vazonik vazonik self-assigned this Apr 28, 2023
@pawellysy
Copy link
Member

Hello @bcmrcool, thanks for your input!

As a workaround you can use the following drop-in modification: https://jsfiddle.net/BlackLabel/aqd2yn0v/

@bcmrcool
Copy link
Author

bcmrcool commented May 4, 2023

Hello @bcmrcool, thanks for your input!

As a workaround you can use the following drop-in modification: https://jsfiddle.net/BlackLabel/aqd2yn0v/

Hi @pawellysy , it doesn't seem to work in my case. Do you know of a resource to help me better understand shapeArgs?

An entire section of my pyramid is chopped off. For what it's worth I do have an additional letter M in my shape args however I'm not really sure what that translates to.

@bcmrcool
Copy link
Author

bcmrcool commented May 5, 2023

hi @pawellysy, for reference here I have a jsfiddle here which is exactly how I've got my chart setup: https://jsfiddle.net/osdm2je8/74/, really appreciate the help

@pawellysy
Copy link
Member

Hi @bcmrcool, thanks for your feedback!
In highcharts, shapeArgs property defines the shape, that each point should have. In case of paths (like most points are created) the d property comes as a SVG Path line command. The docs of the SVG Path you can find here.

In case of your example, the snippet I shared is only a PoC, which shows that this is achievable, but not really a fully working implementation. We'll look into it though

@vazonik vazonik linked a pull request May 12, 2023 that will close this issue
4 tasks
@highsoft-bot highsoft-bot moved this from To do to Review in progress in Development-Flow May 22, 2023
Development-Flow automation moved this from Review in progress to Done May 24, 2023
@bcmrcool
Copy link
Author

hey @vazonik or @TorsteinHonsi , which version of highcharts can we expect to see this change?

@pawellysy
Copy link
Member

@bcmrcool, When the PR gets merged, you can expect the feature to be added in the next release :)

@vazonik
Copy link
Member

vazonik commented May 24, 2023

Hi @bcmrcool, in addition to what @pawellysy said, it's already merged, so if you really want to use it now for testing purposes, you can import the build from: https://github.highcharts.com/modules/funnel.js
(demo: https://jsfiddle.net/BlackLabel/ykdvn8Lz/)

Keep in mind, however, that this is a build of the current state of the main branch, which is constantly changing so it's not suitable for use in production. For that, you should wait for the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Has workaround Type: Feature Request Used when a new feature is requested either directly or indirectly
Projects
Development

Successfully merging a pull request may close this issue.

4 participants