Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y module describes series on each redraw, even if nothing changed #20226

Open
pawellysy opened this issue Nov 29, 2023 · 1 comment
Open

Comments

@pawellysy
Copy link
Member

pawellysy commented Nov 29, 2023

Expected behaviour

The a11y function should fire only, when something changed in the chart.

Actual behaviour

A11y's SeriesDescriber.DescribeSeries method is fired on each redraw, even though nothing changed.

Live demo with steps to reproduce

https://jsfiddle.net/BlackLabel/kw5bpa9x/1/

Visit this demo, open console, and leave logpoint in the SeriesDescriber.describeSeries.
Click anywhere in the chart's plotArea

see, that after every redraw, which is fired on click, the method above is fired.

Product version

Affected browser(s)

v11.2

@oysteinmoseng
Copy link
Member

Internal note: It should only be necessary to re-describe if the rendering of the series has changed (e.g. which points are visible, or their location). For example after changing the data, the visibility of series, or zooming.

Is this a performance issue at the moment, or is it related to a workaround making use of the describeSeries function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants