Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Election demo, minor issues #21041

Open
jomar-honsi opened this issue Apr 19, 2024 · 0 comments
Open

Election demo, minor issues #21041

jomar-honsi opened this issue Apr 19, 2024 · 0 comments

Comments

@jomar-honsi
Copy link
Collaborator

jomar-honsi commented Apr 19, 2024

  • Should 'Votes' really be written with capital V' ? (e.g. ...... **(52.3%) Votes
  • Code style: the chart identifier symbols are misnomers. Suggestion: election-chart-national to be e.g. election-chart-year and election-chart should be election-chart-historical. These names better describe what the chart actually displays.
  • Mobile: the data grid is not scrollable sideways.
  • Mobile: large padding on the left and right of each component - suggest smaller margin/padding in mobile view.
  • Mobile: on the map the data labels are excessively large, suggest decreasing the font and remove the stroke.
  • For widths below 400px the "Electoral College Results" bar becomes increasingly messy:
    • Text on "Republican" side the text does not get clipped, overlapping with the photo
    • Photo no longer centered relative to the bar
    • Suggest placing the text below the bar in mobile view, that may solve both the above issues.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dash
Awaiting triage
Development

No branches or pull requests

1 participant