-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errorbar: not aligned perfectly - sometimes has 1 pixel offset #5334
Comments
@jon-a-nygaard Check the rounding used for the error bar stem. Error bar inherits certain features, check that the issue is fixed as high up in the inheritance chain as possible. |
It also seems that the markers for the scatter series is a little bit skewed towards left. |
If you remove the error bars, the scatter series markers seem to be quite well aligned to the grid lines. The grid lines are rounded to the nearest full pixel. The error bars are also rounded, but seem to be consequently 1px more to the right, so it may be that we are running |
@TorsteinHonsi Thanks, looking at it right now. The scatter markers are not centered on the grid line, but starts drawing on the beginning of the grid line, which can be seen from this image. But I guess there is a logical reason for it. |
Internal Note: The shapeArgs values have already been corrected for crispness, and are therefore not so good for use in calculations. |
Problably the crisping logic of the grid lines is also buggy, so that they are not always crisped to the closest full pixel. So a fix for this issue would require that the grid lines are fixed, which will create a lot of diffs in the visual pixel-by-pixel tests. |
+1 |
Any progress on this? I recently get the same problem. |
Hey there. I've also come across this issue lately. Any progress on updating the crisping logic to fix this? |
+1, pretty annoying |
If you add a The workaround solution was actually provided by @paulo-raca in this ticket: #8558 |
@Andriy-Kulak -- Thanks for looking into it, but that was a workaround to a different problem (The weird spacing and extra passing applied to x-axis when there is a errorbar series). Looking at your example, it continues a little bit off-center. |
@paulo-raca in any case this solution made my the issue much less noticeable in my chart. I attached before and after images |
Wow, I'm puzzled. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions! |
unstale |
Other example of the issue with latest Highcharts and errorbars overlays with scatter (zoomed in): Please can you fix this bug, this issue seem to be known for a very long time. |
Recreated with the highcharts/ts/Series/BoxPlot/BoxPlotSeries.ts Lines 158 to 165 in 0457745
|
I set up a systematic test with gridlines, scatter, error bars and column: https://jsfiddle.net/highcharts/w7gpLsu1/ . See the console for results. The takeaways:
The conclusion is that ticks/gridlines, scatter points and error bars must all be fixed, each one independently, in order to fix this bug. |
Behaviour
Miss-aligned lines e.g. are not placed in center of linkedTo scatter markers.
Live demo with steps to reproduce
http://jsfiddle.net/zkenuwu2/
Plot lines added for reference, but also very much visible in compare to scatter markers.
Affected browser(s)
More visible in Chrome (at least for this demo).
The text was updated successfully, but these errors were encountered: