Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HighMaps: Incorrect Map Properties in map collection provided by HighCharts #5405

Closed
GaneshBChandgude opened this issue Jun 15, 2016 · 6 comments

Comments

@GaneshBChandgude
Copy link

Expected behaviour

For World Map,
iso-a2 corresponds to ISO 3166-1 alpha-1 standard
iso-a3 corresponds to ISO 3166-1 alpha-2 standard

For Country Maps,
hc-key corresponds to ISO 3166-2 standard (for most countries)

Won't it be better to add a proper iso 3166-2 attribute for country maps? Or instead correct the current hc-keys and postal codes for country maps?

Actual behaviour

Many geojsons provided at http://code.highcharts.com/mapdata/ contain incorrect map properties.

Example:
For United Kingdom map, postal codes for many divisions are null. Moreover, the hc-keys for the divisions are not standard. For Anglesey, hc-key is gb-ay which should be gb-agy. For Orkney, hc-key is gb-3270 which should be gb-ork and postal code for the same should be ORK. Refer https://en.wikipedia.org/wiki/ISO_3166-2:GB

For India, Gujarat's hc-key is incorrectly shown as in-2984 which should have been in-gj, and postal code is null, which should have been GJ. Refer https://en.wikipedia.org/wiki/ISO_3166-2:IN

@oysteinmoseng
Copy link
Member

This is a known issue, related to #5105.

The properties added to the maps depend on our source data, which for many areas are lacking. As mentioned in the other issue, you can vote for changes to individual areas on our UserVoice forum.

Which properties are available and an explanation of hc-key (it's not always ISO based) can be found here ("Map Properties" section).

@sventech
Copy link

We've been collecting the latest ISO3166-2 region data for this open source project (MIT):
https://github.com/benkeen/country-region-data -- you could use that to update your maps, at least in cases where you have the correct regions.

@oysteinmoseng
Copy link
Member

@sventech Thank you for that, that looks very useful!

@kamilkulig
Copy link
Contributor

kamilkulig commented Jun 22, 2018

Demo with new filed iso-3166-2 added to GB map: http://jsfiddle.net/BlackLabel/95fwj7dy/

Internal note:
Values of ISO 3166-2 added to source and included as property in output map.

@kamilkulig
Copy link
Contributor

kamilkulig commented Jun 26, 2018

Demo with new filed iso-3166-2 added to India map: http://jsfiddle.net/BlackLabel/rypf1Lnd/

Internal note:
Values of ISO 3166-2 added to source and included as property in output map.

@jon-a-nygaard
Copy link
Contributor

We have created a seperate repository for the map collection, and we are transfering the issues related to the map collection to this new repository.

Please continue the discussion and follow the future development of this issue at highcharts/map-collection-dist#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants