Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors feed caching causes incorrect instance/user counts to show in the feed #3605

Closed
Vadman97 opened this issue Jan 25, 2023 · 0 comments · Fixed by #3565
Closed

errors feed caching causes incorrect instance/user counts to show in the feed #3605

Vadman97 opened this issue Jan 25, 2023 · 0 comments · Fixed by #3565
Assignees
@Vadman97
Labels
bug Something isn't working

Comments

@Vadman97
Copy link
Member

Describe the bug
errors feed caching causes incorrect instance/user counts to show in the feed

To Reproduce
Steps to reproduce the behavior:

  1. visit https://app.highlight.io/errors
  2. click an error in the feed
  3. visit page 2 of the feed
  4. click some errors in the feed
  5. visit page 1 of the feed
  6. click some errors in the feed, and see that the instance/user counts in the left feed preview change upon clicking

Additional context
Likely due to apollo caching data between GetErrorsOpenSearch and GetErrorGroup, and using an incorrect cache key?
@Vadman97 Vadman97 added the bug Something isn't working label Jan 25, 2023
@Vadman97 Vadman97 self-assigned this Jan 25, 2023
@Vadman97 Vadman97 mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vadman97 Vadman97

Labels
bug Something isn't working
Projects
Highlight Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

indexeddb should always make requests that update data highlight/highlight
1 participant
@Vadman97