(csharp) highlight fail: in and out as generic variable modifier

[xp44mm]

this is the jsfiddle:

<pre>
<code class="C#">
interface IObserver&lt;in T&gt;
{
  void OnNext(T item);
  void OnCompleted();
  void OnError(Exception error);
}
interface IObservable&lt;out T&gt;
{
  IDisposable Subscribe(IObserver&lt;T&gt; observer);
}
</code>
</pre>

in and out should be keywords.

[joshgoebel]

jsfiddle please. Having a fiddle makes it easier to track these issues if they remain open a while and also allows developers to see them visually and fix them faster.

You can fork my template:
https://jsfiddle.net/ajoshguy/a1kntyg4/

[xp44mm]

this is the reproduction:
https://jsfiddle.net/0yu49Lf5/

[joshgoebel]

I wonder if we even try to pattern match the <> at all...

[joshgoebel]

@xp44mm If C# is your language this issue might be a great one to get your feet a little wet: #1947

[xp44mm]

maybe the highlightjs should split into two parts: tokenizer and render. people contribute their tokenizer will be easier.

[joshgoebel]

If all you want is the CSS, it's pretty easy to build the tokenizer -> html side and then just use our stylesheets. We're talking about stuff like that, but I'd rather see our parser get more powerful than people write their own parser for every language, that would be a bore.

[joshgoebel]

maybe the highlightjs should split into two parts: tokenizer and render. people contribute their tokenizer will be easier.

I'm not sure for most people contributing a lexer would be simpler than contributing a list of regex patterns to match...

Do you have a full JS tokenizer/lexer for C# though? If so I'd be interested in exploring how someone MIGHT integrate such a thing as a plugin. But my original point stands that if one has a parse tree already just turning it into HTML is the EASY part... you could simply wrap Highlight.js fairly easily. (though you don't need it at all at that point, just the CSS files)

[joshgoebel]

What else are " generic variable modifier"s supported on other than interfaces?

Are in and out the only modifiers?