Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Adding CpcdosC+ support language. #2493

Closed
sebastien-favier opened this issue Apr 13, 2020 · 3 comments
Closed

[Request] Adding CpcdosC+ support language. #2493

sebastien-favier opened this issue Apr 13, 2020 · 3 comments
Labels
enhancement An enhancement or new feature

Comments

@sebastien-favier
Copy link

sebastien-favier commented Apr 13, 2020

Hi, we are a growing community around the Kernel Cpcdos project, we are using CpcdosC+ syntaxic language since 9 years. Now we'd love to port our language to highlight.js, you can find the repository Here

We are looking forward to hear about your opinion!
Sincerly yours,

SPinti Software,
Sébastien FAVIER

@sebastien-favier sebastien-favier added the enhancement An enhancement or new feature label Apr 13, 2020
@joshgoebel
Copy link
Member

From our documentation

Highlight.js doesn't have a fundamental plan for implementing languages, instead the project works by encouraging development of 3rd party language grammars from contributors. We're also happy to host 3rd party language grammars at the highlightjs GitHub organization - no matter how obscure or weird.

This means that there's no point in requesting a new language without providing an implementation for it. If you want to see a particular language included in highlight.js but cannot implement it, the best way to make it happen is to get another developer interested in doing so. Here's our :doc:language-guide.

If you're interested in developing your own 3rd party language module start with: https://github.com/highlightjs/highlight.js/blob/master/extra/3RD_PARTY_QUICK_START.md

We'd love to have you!

@joshgoebel
Copy link
Member

joshgoebel commented Apr 14, 2020

Oh you already did it! LOL.

  • Please consider building and adding the dist folder to your repository to make it easy for uses to drop your 3rd party language into their website with zero difficulty.
  • Please consider a much longer README along the lines of some of the other 3rd party languages (just click thru our organization to see example) with documentation explaining how to use your plugin

But regardless if you make a PR to add your language to the table in SUPPORTED_LANGUAGES.md we'll get it merged.

@sebastien-favier
Copy link
Author

sebastien-favier commented Apr 14, 2020

Nice thank you !
We take care of all that ;)

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants